Introduce managed query execution on Driver level #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/execute-query-api
branch
5 times, most recently
from
24756ef to
ff1f4fd
Compare
michael-simons
requested changes
Jan 17, 2023
driver/src/main/java/org/neo4j/driver/ResultTransformerProvider.java
Outdated
Show resolved
Hide resolved
driver/src/main/java/org/neo4j/driver/ResultTransformerProviders.java
Outdated
Show resolved
Hide resolved
michael-simons
requested changes
Jan 18, 2023
There was a problem hiding this comment.
I agree on your slack remark this being too many overloads. However, it feels more natural to me not having the transformer as part of the config.
I would most like go with
- Having only
Queryobjects in the simple api - Adding
ofmethod toQueryclass, such asQuery.of(cypher)andQuery.of(cypher, params), so that it is still nicely readable
I don't really understand the "Having a single object that would capture both the collector and the result summary handler." remark, but I feel like I don't want this, it's more cruft.
|
Oh, adding some heresy… |
injectives
force-pushed
the
feature/execute-query-api
branch
from
e3efcdc to
d6c0bcc
Compare
injectives
changed the title
injectives
force-pushed
the
feature/execute-query-api
branch
2 times, most recently
from
0f04c03 to
a08bbb2
Compare
This is a new basic high-level API for executing idempotent queries.
injectives
force-pushed
the
feature/execute-query-api
branch
from
a08bbb2 to
01fccf0
Compare
michael-simons
approved these changes
Jan 23, 2023
gjmwoods
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new basic high-level API for executing idempotent queries.